Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are the tests done using multiple threads? #4

Open
Pirulax opened this issue Jun 28, 2023 · 3 comments
Open

Are the tests done using multiple threads? #4

Pirulax opened this issue Jun 28, 2023 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Pirulax
Copy link

Pirulax commented Jun 28, 2023

First of all, thanks for the great library.
I'm [possibly] planning to use it, but I'm just wondering about one thing...

Looking at the tests, it seems like they aren't done using multiple threads, but rather on a single one.
Am I missing something?

@DNedic
Copy link
Owner

DNedic commented Jun 28, 2023

Hello @Pirulax , thanks for the interest, the tests are unit tests and they only test the correctness of the logic, not thread safety.

I've been meaning to make thread safety tests but it's a very tricky thing to make reliably. Still, it's on my TODO list.

I'd welcome anyone that contributed them to the library, so if you have time you can try your hand.

@DNedic DNedic added enhancement New feature or request help wanted Extra attention is needed labels Jun 28, 2023
@Pirulax
Copy link
Author

Pirulax commented Jun 28, 2023

I see. I think that's something that should be highlighted in the README.

@DNedic
Copy link
Owner

DNedic commented Dec 27, 2023

After #15, there are only MPMC data structures lacking multi-threaded tests, however I am not sure how we would be able to test the correct order of element placements in respect to time. Testing if all elements are there should be trivial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants