Feature/update to go 1.17 #223
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnephin
reviewed
Oct 23, 2021
added 16 commits
October 23, 2021 18:05
This reverts commit b7dcbd2.
aidan-mundy
force-pushed
the
feature/update-to-go-1.17
branch
from
5c71ae6
to
79863c9
Compare
|
Should be all set @dnephin. Forgot to mention in the OP that this MR was built and tested using itself, I haven't tested building it with an older version of Dobi, but it should be fine. |
This was referenced Oct 27, 2021
dnephin
reviewed
Nov 6, 2021
| github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51 | ||
| github.com/lithammer/dedent v1.1.0 | ||
| github.com/metakeule/fmtdate v1.1.2 | ||
| github.com/moby/moby v20.10.9+incompatible |
There was a problem hiding this comment.
I'm not sure about using moby/moby here. Does docker/docker not work? All the imports at moby/moby are still docker: ex: https://github.com/moby/moby/blob/master/image/image.go#L1
And we have github.com/docker/docker v20.10.9+incompatible below, which makes me think this is not being included twice. I think we should import docker/docker and use it as the module as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates a lot of dependencies and dockerfiles in the project to use the (near) latest versions.
Includes the changes from #219 #220 #221 #222 because some of them were required for proper operation, and I didn't feel like messing around with the git history. I can separate them out if requested. I would suggest reviewing and merging those PRs before this one.