-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup/refactor actions #228
Draft
aidan-mundy
wants to merge
22
commits into
dnephin:main
Choose a base branch
from
aidan-mundy-forks:cleanup/refactor-actions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Cleanup/refactor actions #228
aidan-mundy
wants to merge
22
commits into
dnephin:main
from
aidan-mundy-forks:cleanup/refactor-actions
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b7dcbd2.
A future optimization to these changes would be to frontload action parsing during the config reading process and store Name items instead of raw strings, instead of passing errors all over the place if dependency parsing fails later. |
9c2b470
to
0cf5bc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #223 (includes commits from that PR)
Depends on #226 (includes commits from that PR)
Relates to #227
This is a large refactor of how actions/dependencies are handled.
It resolves item 2 in #227, and as far as I can tell it also resolves item 1 in #227 (prior to these updates, dependencies would sometimes be built before deleting the "depended")
NOTE: Marked as draft for now because resolving items 1&2 causes item 3 to be much more noticeable.