Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add host setting option and ability to use settings outside module context #4153

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Add host setting option and ability to use settings outside module context #4153

merged 1 commit into from
Oct 6, 2020

Conversation

donker
Copy link
Contributor

@donker donker commented Oct 6, 2020

This PR does two things:

  1. It adds the (IMO missing) HostSettingsAttribute which persists the value to the HostSettings table
  2. It allows you to construct the settings repository with a simple PortalId to retrieve a settings class with only portal/host settings

Because of #2 you can also create a settings class using -1 for portal ID which allows you to use only HostSettings.

@bdukes bdukes added this to the 9.8.0 milestone Oct 6, 2020
@sleupold
Copy link
Contributor

sleupold commented Oct 6, 2020

wouldn't it make sense at this state to introduce multilingual support for HostSettings as well?

@mitchelsellers mitchelsellers modified the milestone: 9.8.0 Oct 6, 2020
@mitchelsellers mitchelsellers merged commit c26a2ca into dnnsoftware:develop Oct 6, 2020
@donker donker deleted the improvesettings branch October 6, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdukes bdukes bdukes approved these changes

@mitchelsellers mitchelsellers mitchelsellers approved these changes

Assignees
No one assigned
Labels
Type: Enhancement
Projects
None yet
Milestone
9.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@donker @sleupold @bdukes @mitchelsellers