Apply analyzer (StyleCop) auto-fixes #5337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I generated an API diff (which helped me track down places where |
bdukes
force-pushed
the
analyzer-fixes
branch
from
40c4055
to
3989a84
Compare
|
Previous build: 25,628 warnings |
mitchelsellers
approved these changes
Oct 17, 2022
bdukes
force-pushed
the
analyzer-fixes
branch
from
3989a84
to
021f81e
Compare
bdukes
force-pushed
the
analyzer-fixes
branch
from
021f81e
to
72337e9
Compare
bdukes
added a commit
to bdukes/Dnn.Platform
that referenced
this pull request
Nov 11, 2022
PR dnnsoftware#5337 implemented auto-fixes for style issues, but the renaming of backing fields sometimes caused a conflict which resulted in the property becoming recursive
donker
pushed a commit
that referenced
this pull request
Nov 11, 2022
PR #5337 implemented auto-fixes for style issues, but the renaming of backing fields sometimes caused a conflict which resulted in the property becoming recursive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I ran Code Cleanup from Visual Studio 2022 with the Fix analyzer warnings and errors set in EditorConfig option, and then resolved a couple of issues it created. I've closely reviewed and tweaked about half of the files.
It primarily adjusting naming conventions (removing underscores, making arguments and privates lowercase).
I also fixed an incorrect reference of SharpZipLib in Dnn.PersonaBar.Extensions (not sure why it wasn't causing trouble before).