Zeros store negative

[karasjoh000]

Not sure if it is intended but zeros store negatives inside. When I print a zero fraction I get -0.

[karasjoh000]

not all zeros but I think after a number turns into a 0 from a negative on the Ops.

[karasjoh000]

Although if it returns equals on -0 and 0 it should be fine. Did not have time to check yet.

[dnsl48]

yes, that's been intentional so far. We even have a separate method Fraction::neg_zero().

However, now I'm contemplating the actual benefits of having negative zeroes. Rust core float implementation does handle negative zeroes and zeroes as the same thing, so do we to be compatible. I'm not sure we need this any more. Perhaps worth deprecating and removing them.

[dnsl48]

Although if it returns equals on -0 and 0 it should be fine. Did not have time to check yet.

Yes, they are equals. We have it covered with tests
https://github.com/dnsl48/fraction/blob/master/src/fraction/mod.rs#L2746

If you have any other questions or recommendations that we can consider when deciding on if it's worth deprecating negative zeroes and removing those, please feel free to leave them here and reopen or make a new issue.

Cheers