Missing Clone bound causes compilation of 0.3.5 to fail

[phrohdoh]

   Compiling fraction v0.3.5
error[E0277]: the trait bound `T: std::clone::Clone` is not satisfied
   --> /Users/thill/.cargo/registry/src/github.com-1ecc6299db9ec823/fraction-0.3.5/src/lib.rs:149:21
    |
149 |     Rational (Sign, Ratio<T>),
    |                     ^^^^^^^^^ the trait `std::clone::Clone` is not implemented for `T`
    |
    = help: consider adding a `where T: std::clone::Clone` bound
    = note: required because of the requirements on the impl of `std::hash::Hash` for `num::rational::Ratio<T>`
    = note: required by `std::hash::Hash::hash`

error[E0277]: the trait bound `T: num::Integer` is not satisfied
   --> /Users/thill/.cargo/registry/src/github.com-1ecc6299db9ec823/fraction-0.3.5/src/lib.rs:149:21
    |
149 |     Rational (Sign, Ratio<T>),
    |                     ^^^^^^^^^ the trait `num::Integer` is not implemented for `T`
    |
    = help: consider adding a `where T: num::Integer` bound
    = note: required because of the requirements on the impl of `std::hash::Hash` for `num::rational::Ratio<T>`
    = note: required by `std::hash::Hash::hash`

error: aborting due to previous error(s)
error: Could not compile `fraction`.
Build failed, waiting for other jobs to finish...
error: build failed

[phrohdoh]

These changes fixed compilation but I do not know if they are the correct, desired changes:

diff --git a/src/lib.rs b/src/lib.rs
index ed12b8c..778d3fe 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -145,7 +145,9 @@ impl fmt::Display for Sign {
 /// assert_eq! (first + second, F::new (3, 4));
 /// ```
 #[derive (Clone, Hash, Debug)]
-pub enum GenericFraction<T> {
+pub enum GenericFraction<T>
+    where T: Clone + Integer
+{
     Rational (Sign, Ratio<T>),
     Infinity (Sign),
     NaN
@@ -154,7 +156,7 @@ pub enum GenericFraction<T> {
 
 
 /// Copy semantics to be applied for the target type, but only if T also has it.
-impl<T> Copy for GenericFraction<T> where T: Copy {}
+impl<T> Copy for GenericFraction<T> where T: Copy + Integer {}
 
 
 
@@ -1522,7 +1524,7 @@ impl<T: Clone + Integer> /*Float for*/ GenericFraction<T> {
 
 
 
-impl<T: fmt::Display + Eq + One> fmt::Display for GenericFraction<T> {
+impl<T: fmt::Display + Eq + One + Clone + Integer> fmt::Display for GenericFraction<T> {
     fn fmt (&self, f: &mut fmt::Formatter) -> fmt::Result {
         match *self {
             GenericFraction::NaN => write! (f, "NaN"),

[dnsl48]

Woah, it seems like in spite of having a dependency num = 0.1.37, cargo is still trying to install the latest 0.1.40, which seems to have some breaking changes around Ratio requirements.

[phrohdoh]

To require exactly 0.1.37 you want num = "=0.1.37" I believe.

[dnsl48]

Yes, that is so. However, even that doesn't help in this particular case, since num itself does only apply semver requirements for its subpackages - so the latest ratio module is going to be installed every time.

[dnsl48]

Anyway, the fix seems to be correct, since we can only operate with integers. I'll make the patch, thank you!

[dnsl48]

v0.3.6 with the fix has been published