Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/monorepo rebased #51

Merged
merged 7 commits into from
Feb 22, 2021
Merged

Feat/monorepo rebased #51

merged 7 commits into from
Feb 22, 2021

Conversation

kanej
Copy link
Contributor

@kanej kanej commented Feb 22, 2021

Rebased version of #49.

vaultec81 and others added 5 commits February 22, 2021 10:01
* refactor (docs): Restructure docs, nice it up

Add more badges, a logo
Center text and logo
Improve table of contents
Center text

* feat (docs): move develop & publishing to separate md

* feat (docs): add feature list

* feat (docs): add feature list

* feat (docs): add twitter follow badge

* fix (docs): remove left over stuff

* feat (docs): add additional badges

* Update README.md

* Update README.md

* Update README.md

* Create README.md

* Create README.md

* Create README.md

* Create README.md

* Update README.md

* Update README.md

* Update README.md

* Create .all-contributorsrc

* Delete .all-contributorsrc

* fix: TOC links, add use cases in TOC

* feat: add use cases to readme

* fix: TOC item

* feat: move to monorepo

* feat: add additional lerna config

* Merge mailscript-main to main

* fix: docs folder remove extra files.

* feat: create API.md

* feat (docs): add annotated workflow

* feat (docs): add contributor info, templates.

* feat (docs): add combined workflow, fix up readme

Co-authored-by: Shokunin <30949000+leshokunin@users.noreply.github.com>
All templates are now able to be imported with
`mailscript sync:import -p config.yml`.

The only notable exception is "two-alerts-to-sms" since some
triggers seem to be unaccounted for. Those are `--times` and
`--seconds`.
CONTRIBUTING.md Show resolved Hide resolved
@kanej kanej requested a review from AquiGorka February 22, 2021 10:46
Copy link
Contributor

@AquiGorka AquiGorka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merged. What's the reason for the tests to be failing?

The other lints are specific to the main package and inappropriate at the github action yml level.
@kanej
Copy link
Contributor Author

kanej commented Feb 22, 2021

Let's get this merged. What's the reason for the tests to be failing?

The format check under github actions was doing some typescript specific things based on the assumption the command was run from the root. I have paired the format check back to just format so it can be used through lerna.

@kanej kanej merged commit e28d672 into main Feb 22, 2021
@kanej kanej deleted the feat/monorepo_rebased branch February 22, 2021 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants