Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix templates' READMEs #52

Merged
merged 3 commits into from
Feb 25, 2021
Merged

Fix templates' READMEs #52

merged 3 commits into from
Feb 25, 2021

Conversation

Geo25rey
Copy link
Contributor

No description provided.

Copy link
Contributor

@kanej kanej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, swap in the new urls and your done.

"driveStoragePath": "path/to/save/pdfs/in/for/google/drive",
"googleDriveAuth": "{{integrations.google}}"
}
url: "http://localhost:5001/mailscript-firebase/us-central1/googleDrivePdfUploader"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets give the cloud function endpoint for this.

}
url: "https://write-to-csv-endpoint.url"
url: "http://localhost:5001/mailscript-firebase/us-central1/googleDrivePdfUploader"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And similarly here. I have pushed the cloud functions so it should be available.

@AquiGorka AquiGorka merged commit ced9e51 into main Feb 25, 2021
@AquiGorka AquiGorka deleted the fix/templates branch February 25, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants