Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malformed SCSS when using the 'flat' option #55

Closed
jtestarkey opened this issue Feb 1, 2022 · 8 comments · Fixed by #56
Closed

Malformed SCSS when using the 'flat' option #55

jtestarkey opened this issue Feb 1, 2022 · 8 comments · Fixed by #56

Comments

@jtestarkey
Copy link

When using the flat option with newer versions of tailwind, the scss is malformed, e.g.:

image

Is there any way to ignore the variables that have illegal characters?

@dobromir-hristov
Copy link
Owner

dobromir-hristov commented Feb 1, 2022

We could just add escaping for the full stop? $height-2\.5: 2rem

@jtestarkey
Copy link
Author

Yeah that would be better!

@jtestarkey
Copy link
Author

Hey @dobromir-hristov is this something you would be able to look at, or can you point me in the right direction and I'll have a look at it myself? Thanks!

@dobromir-hristov
Copy link
Owner

Extremely busy with my day job, so I have not had time to look into this.

There is a sanitizer function on each class, so I guess it's a matter of just doing some simple string replacement.

Which version of the library are you using?

@jtestarkey
Copy link
Author

Not a problem, I understand. Currently using a old version of both this package and tailwind, but trying to upgrade both to latest.

@dobromir-hristov
Copy link
Owner

New versions have some extra fixes, so this may be fixed already

@jtestarkey
Copy link
Author

Sorry, it currently 'works' in the older version but that's because that version of tailwind doesn't have the 0.5 variables.
Latest versions of both currently doesn't work due to those variable names.

@mjcbsn22
Copy link

+1

Tried updating to either 3.x or 4.x today and ran into the same issue

Reason for the upgrade urgency is because v2.3.1 depends on postcss@6.0.23 through tailwindcss -> postcss-functions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants