Skip to content
This repository has been archived by the owner on Aug 20, 2021. It is now read-only.

Oscalkit failing to parse profile where an https import, imports a relative path. #70

Closed
farhankamalkhan-10p opened this issue Jan 28, 2019 · 3 comments

Comments

@farhankamalkhan-10p
Copy link
Contributor

farhankamalkhan-10p commented Jan 28, 2019

Related to: #57

When executing oscalkit generate code and processing a profile that has been imported using an https:// link, if that profile internally imports a profile/catalog relatively, the path is resolved incorrectly by appending the current system relative path to the https:// path of the parent profile that has imported the catalog/profile. The problem lies in the parentPath handing in:
https://github.com/docker/oscalkit/blob/c5a92172971fa7ea1ccfdf7b08f67ed5bae53683/generator/profile.go#L44

cc: @minhaj10p @anweiss

@anweiss
Copy link
Contributor

anweiss commented Jan 28, 2019

Good catch @farhan-khan30

@minhaj10p
Copy link
Contributor

addressed in #71
@farhan-khan30 @anweiss

@farhankamalkhan-10p
Copy link
Contributor Author

Verified fix in #71. Closing.
@anweiss @minhaj10p

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants