This repository has been archived by the owner on Aug 20, 2021. It is now read-only.
Import path #58
Merged
Import path #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asadullah-yousuf-10p
suggested changes
Jan 23, 2019
|
@minhaj10p #62 has been merged. Please rebase. I still need a couple of other reviews on on #52 before we can merge that, and then subsequently this. |
minhaj10p
force-pushed
the
import-path
branch
2 times, most recently
from
2f97aeb
to
1a8bc91
Compare
PRs rebased. |
This was referenced Jan 24, 2019
Merged
|
@minhaj10p please rebase now that #52 has been merged. |
minhaj10p
force-pushed
the
import-path
branch
from
1a8bc91
to
298aeb1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #57
In a scenario where
oscalkit generate -p /someDir/profile.xmlis run, andprofile.xmlhas a relative import like../catalog.xml, then the directory that will be searched is/someDir