Skip to content
This repository has been archived by the owner on Aug 20, 2021. It is now read-only.

Add sub commands for generate cmd #62

Merged
merged 1 commit into from
Jan 23, 2019

Conversation

minhaj10p
Copy link
Contributor

@minhaj10p minhaj10p commented Jan 23, 2019

Description

Adds subcommands to the parent generate command; enabling json/xml catalogs and, go catalogs and Prose parsing yet to be developed.

Links

Partially addressess issue #61. catalog.Prose parsing is yet to be addressed

Copy link
Contributor

@asadullah-yousuf-10p asadullah-yousuf-10p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one update required. Otherwise, LGTM.

// Catalog generates json/xml catalogs
var Catalog = cli.Command{
Name: "catalogs",
Usage: "generates json/xml catalogs provided profile",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Usage: "generates json/xml catalogs provided profile",
Usage: "generates json/xml catalogs when provided with a profile",

Copy link
Contributor

@anweiss anweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anweiss anweiss merged commit 2f8e944 into docker-archive:master Jan 23, 2019
@anweiss anweiss mentioned this pull request Jan 23, 2019
@minhaj10p minhaj10p deleted the subcommand branch January 23, 2019 19:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants