Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal, ex2.8: clarify trailing slash backend_connection_url #147

Closed
protofarer opened this issue Feb 6, 2022 · 1 comment
Closed

Comments

@protofarer
Copy link

protofarer commented Feb 6, 2022

I embarrassingly spent too many hours to count troubleshooting why my backend didn't respond to /api/ping through the frontend. Depending on course philosophy, it may be advisable to clarify the information block about the backend in exercise 2.8, specifically:

"It might be nginx configuration problem: Add trailing / to the backend url in the nginx.conf."

I misread this as meaning the location block's prefix pattern /api/ 's trailing slash. Indeed, without much knowledge about how NGINX conf flow works, I didn't make the (obvious in retrospect) connection with _backend_connection_url_. While the learning experience of tinkering with nginx.conf and solidifying my understanding of docker-compose networks was very useful (paralleling what real-world problem-solving is like), this may slow down desired progression rate for the student.

Suggestion: Make the ex2.8 information block more explicit, eg:

Option 1: "Ensure there is a trailing / on the backend url as specified under the location /api/ context in the nginx.conf."

Option 2: "Ensure there is a trailing / on _backend_connection_url_ in the nginx.conf."

Thanks!
~k

@mluukkai
Copy link
Collaborator

mluukkai commented Mar 5, 2023

Picked option 1 for the upcoming edition!

@mluukkai mluukkai closed this as completed Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants