-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dependencies to support Docker for OSX. #677
Conversation
This seems to fail in the integration tests for me when using Docker for Mac. When running under Docker Machine on Mac it seems to be OK. The failure looks to be as follows:
(Interestingly Run 2-95 say PASS, but I'm not quite sure what's going on there) This is occurring with Docker for Mac Version 1.12.0-rc3-beta18 (build: 9996). |
Maybe somebody wants add osx build for travis? |
<version>${unix-socket-factory.version}</version> | ||
<groupId>com.kohlschutter.junixsocket</groupId> | ||
<artifactId>junixsocket-common</artifactId> | ||
<version>2.0.4</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when version used in 2 places, then it makes set to set it as property
I too saw the failure in the integration tests on OSX. I assumed it was because the tests were linux only. |
Do you know where the "java.lang.IllegalStateException: Only supported on Linux" is coming from? I couldn't see it in the source code. |
Ok I have fixed the version thing you requested and made the netty tests be skipped when you are not on linux and trying to use unix domain sockets. |
Fixed by disabling? |
Yes, throw SkipException() - the netty support will error out otherwise. |
Is this no good? |
I was testing the changes, and in general they work fine, i.e. I was able to connect to Docker for Mac via its unix socket. But I'm getting a lot of
|
Sounds like an abrupt close, which is what is happening in the other case. You probably get a more orderly shutdown with TCP. It may just be that the exceptions need to be squelched. Do you have full stacktraces? |
@andyp1per even now part of tests fails on socket connection. See travis build. As high priority i made green for tcp 1.12 and 1.11. Socket need to be fixed also. |
Can you point me at the build you are looking at? I did look at travis earlier but it seems like the overall docker-java builds were not green either so assumed that it was something else. |
@andyp1per travis doesn't set multiple context statuses, so it have 2 green builds and 4 bad - overall bad. Just click, open build log and failed will be in the end. (Travis doesn't parse/visualise test results). |
|
Note they may fail before or maybe new one fails. |
I don't see how the socket tests can be affected - this only affects unix domain sockets. The other errors look like an attempt to read from a closed stream. My guess is that the contract is slightly different between SocketImpl and AFUNIXSocketImpl |
I'm really not following you here - I went through all the failed jobs in the travis link (https://travis-ci.org/docker-java/docker-java/builds/154979844) above and they are all failing in the same way that the master branch is failing. Which travis build is failing the way you describe - please post a link? |
dependencies updated within #697 |
Thanks for doing this |
Fix dependencies to support Docker for OSX.
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)