Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/wp-content/uploads indexing #33

Closed
scjudd opened this issue Dec 15, 2014 · 3 comments · Fixed by docker-library/php#66
Closed

/wp-content/uploads indexing #33

scjudd opened this issue Dec 15, 2014 · 3 comments · Fixed by docker-library/php#66
Assignees

Comments

@scjudd
Copy link

scjudd commented Dec 15, 2014

Right now you can browse the /wp-content/uploads directory of a site deployed from this image.

I've fixed this by adding the following line to each of my derived images:

RUN sed -i 's/Indexes //g' /etc/apache2/apache2.conf

I'm sure there's a less dangerous way of doing the above, but I'm thinking that disabling indexes should be the default behavior. Thoughts?

@yosifkit
Copy link
Member

You are right, Indexes should be turned off. Maybe just a change in the .htaccess would be simpler?

@scjudd
Copy link
Author

scjudd commented Dec 15, 2014

Sounds good to me, especially since we're already using .htaccess for apache configuration.

@tianon
Copy link
Member

tianon commented Dec 15, 2014

Shouldn't we just change the default config in php:apache directly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants