Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quotes to meet style guidelines #2330

Merged
merged 5 commits into from
Dec 21, 2021

Conversation

casperklein
Copy link
Member

@casperklein casperklein commented Dec 19, 2021

Description

This PR remove quotes in if-statements, to meet the projects style guidelines

Fixes #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein self-assigned this Dec 19, 2021
@casperklein casperklein added area/scripts kind/improvement Improve an existing feature, configuration file or the documentation labels Dec 19, 2021
@casperklein casperklein changed the title Remove quotes Remove quotes to meet style guidelines Dec 19, 2021
@casperklein casperklein marked this pull request as ready for review December 19, 2021 15:25
@casperklein casperklein requested a review from a team December 19, 2021 15:25
@georglauterbach georglauterbach added this to the v10.4.0 milestone Dec 19, 2021
@casperklein casperklein mentioned this pull request Dec 20, 2021
4 tasks
@polarathene

This comment was marked as outdated.

@georglauterbach
Copy link
Member

The network issue seems to have lasted longer. I've restarted the tests again.

@github-actions
Copy link
Contributor

Documentation preview for this PR is ready! 🎉

Built with commit: cd48abb

@georglauterbach
Copy link
Member

@casperklein when you merge this, please remove the other label from the new version's PR :)

@casperklein casperklein merged commit d46e094 into docker-mailserver:master Dec 21, 2021
@casperklein casperklein deleted the remove-quotes branch December 21, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/scripts kind/improvement Improve an existing feature, configuration file or the documentation priority/low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants