Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support annotations option #958

Closed
Tracked by #454
favonia opened this issue Sep 11, 2023 · 3 comments · Fixed by #992
Closed
Tracked by #454

Support annotations option #958

favonia opened this issue Sep 11, 2023 · 3 comments · Fixed by #992
Labels
kind/enhancement New feature or request

Comments

@favonia
Copy link
Contributor

favonia commented Sep 11, 2023

Description

(I am creating a new issue because the focus of the old issue #854 is unclear.)

I wish build-push-action can support annotations just like labels, once the new --annotation shortcut (docker/buildx#2020) is officially available. Essentially, the script should append a new parameter --annotation "line" for each line in the value of annotations, just like how it appends a new --label "line" now for each line in the value of labels.

@favonia favonia added kind/enhancement New feature or request status/triage labels Sep 11, 2023
@crazy-max
Copy link
Member

--annotation flag PR has just been merged on buildx repo docker/buildx#2020 and will be available on next 0.12 release. We could then add a new input for this action as follow-up. (cc @jedevc)

@jedevc
Copy link
Contributor

jedevc commented Sep 11, 2023

@crazy-max sgtm 🎉 I think the release of v0.12 should be scheduled for fairly soon?

@crazy-max
Copy link
Member

I think the release of v0.12 should be scheduled for fairly soon?

Yes maybe an RC next week 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants