Disable provenance by default if not set #781
Merged
+47
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
force-pushed
the
disable-provenance
branch
2 times, most recently
from
078bb7a
to
66a5cb4
Compare
crazy-max
force-pushed
the
disable-provenance
branch
from
66a5cb4
to
b71223d
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
disable-provenance
branch
from
b71223d
to
838bf90
Compare
jedevc
approved these changes
Jan 30, 2023
1 task
chanange
added a commit
to 20treeAI/github-workflows
that referenced
this pull request
Feb 14, 2023
ruffsl
added a commit
to ros-planning/navigation2
that referenced
this pull request
Mar 20, 2023
by setting provenance to false now tath provenance is enabled by default as of v4 of docker/build-push-action - docker/build-push-action#781 - docker/build-push-action#778
ruffsl
added a commit
to ros-planning/navigation2
that referenced
this pull request
Mar 20, 2023
* Use github action expression syntax to alias over github repository name * Tag by version instead of by timestamp * Avoid pushing untagged image to GHCR by setting provenance to false now that provenance is enabled by default as of v4 of docker/build-push-action - docker/build-push-action#781 - docker/build-push-action#778
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
related to docker/buildx#1533
fixes #780
fixes #778
fixes #771
If
provenancenot specified but Buildx version compatible for attestation, disable provenance anyway. While the action successfully pushes OCI compliant images to well-known registries, some runtimes (e.g. Google Cloud Run and AWS Lambda) are not able to pull resulting image from their own registry.When merged we are going to create a v3.3.1 patch release. In follow-up we will create a v4.0.0 release that keeps provenance enabled, just like v3.3.0.