Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Enable inspection (aka "shallow pull") of images' manifest info, and also the creation of manifest lists (aka "fat manifests").
The workflow for creating a manifest list will be:
There is also a
To be more in line with the existing external manifest tool, there is
Signed-off-by: Christy Norman Perez email@example.com
- What I did
- How I did it
- How to verify it
- Description for the changelog
See moby/moby#27455 for history.
Thanks for moving this PR over to the docker/cli repo!
This PR is quite large! It would be much easier to review if it could be split up and submitted incrementally. Would it be possible to include just one or two sub commands at first? The YAML config I think could be added later on.
We'd like to keep a separation between the
@dnephin It would be a lot of work to split things back out. I realize it would be easier to review and I of course don't want to make reviewers' lives harder -- but at the same time, I would appreciate some compromise. To use your yaml suggestion as an example, I was asked to remove the yaml func, then to add it back in, so I've already been through this twice with the yaml feature alone. I'm not trying to be stubborn -- just asking for a little mercy where it can be given (without sacrificing project integrity, of course).
As for including only a few of the sub-commands, none of the ones there make sense without all the others, except maybe
As for your other point about splitting some of it out into another package, I think that makes sense and I can look into it.