Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fig up and attach should exit when processes exit #1

Closed
bfirsh opened this issue Jan 2, 2014 · 0 comments · Fixed by #165
Closed

fig up and attach should exit when processes exit #1

bfirsh opened this issue Jan 2, 2014 · 0 comments · Fixed by #165

Comments

@bfirsh
Copy link

bfirsh commented Jan 2, 2014

No description provided.

@aanand aanand mentioned this issue Mar 4, 2014
Closed
@aanand aanand mentioned this issue Mar 20, 2014
Closed
aanand added a commit that referenced this issue Mar 25, 2014
@aanand
Stop 'fig up' when a container exits
859d4bb 
Closes #1 ヽ(*・ω・)ﾉ
@aanand aanand mentioned this issue Mar 25, 2014
Merged
dnephin referenced this issue in dnephin/compose Sep 23, 2014
@dnephin
Merge pull request #1 from dnephin/replace_packages_with_deps
1db949f 
Replace packages with deps
@ksylvan ksylvan mentioned this issue Nov 11, 2014
Closed
oscarpicas referenced this issue in oscarpicas/fig Feb 4, 2015
@oscarpicas
Merge pull request #1 from docker/master
84d6b37 
Update
@dmitry-saritasa dmitry-saritasa mentioned this issue Feb 13, 2015
Closed
@bergtwvd bergtwvd mentioned this issue Mar 23, 2015
Closed
chernjie referenced this issue in chernjie/compose Mar 23, 2015
@sampwing
Merge pull request #1 from tdesvenain/master
c0abe43 
Fix when pyyaml has interpreted line as a dictionary
yuval-k pushed a commit to yuval-k/compose that referenced this issue Apr 10, 2015
@aanand
Stop 'fig up' when a container exits
4c20554 
Closes docker#1 ヽ(*・ω・)ﾉ

Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
@adminrezo adminrezo mentioned this issue Apr 24, 2015
Closed
@djsly djsly mentioned this issue Jun 17, 2015
Closed
@icy icy mentioned this issue Jun 29, 2015
Closed
@andrerom andrerom mentioned this issue Sep 5, 2015
Closed
@yajo yajo mentioned this issue Nov 12, 2015
Closed
@ericm24 ericm24 mentioned this issue Feb 1, 2016
Closed
@a1exus a1exus mentioned this issue Apr 14, 2016
Closed
@cristinelvasluianu cristinelvasluianu mentioned this issue May 10, 2016
Closed
@alexellis alexellis mentioned this issue May 28, 2016
Closed
@irfancode irfancode mentioned this issue Sep 20, 2016
Closed
@xiaoxuan220 xiaoxuan220 mentioned this issue Sep 21, 2016
Closed
@korbai korbai mentioned this issue Oct 29, 2016
Closed
@sandokandias sandokandias mentioned this issue Dec 15, 2016
Closed
@daniel-smith-kaazing daniel-smith-kaazing mentioned this issue May 3, 2017
Closed
@fireboy1919 fireboy1919 mentioned this issue Jul 27, 2017
Closed
@thedeeno thedeeno mentioned this issue Nov 22, 2017
Closed
shin- pushed a commit that referenced this issue Jan 18, 2018
@iangneal
Merge pull request #1 from shin-/5465-no-image-error
bd0adb6 
Remove rebuild parameter ; set do_build instead

Signed-off-by: Ian Glen Neal <ian.gl.neal@gmail.com>
@stlouisn stlouisn mentioned this issue Mar 20, 2018
Closed
@raspi raspi mentioned this issue Apr 17, 2018
Closed
@pgerhard pgerhard mentioned this issue Jun 6, 2018
Closed
@MichaelLeeHobbs MichaelLeeHobbs mentioned this issue Jan 15, 2019
Closed
@rdissertori rdissertori mentioned this issue Jul 7, 2019
Closed
@khairmuhammad khairmuhammad mentioned this issue Oct 29, 2019
Closed
@uuf6429 uuf6429 mentioned this issue Nov 16, 2019
Closed
@RSWilli RSWilli mentioned this issue Nov 23, 2019
Closed
cstyles added a commit to cstyles/compose that referenced this issue May 1, 2020
@cstyles
Speed up fish completions for subcommands
5f28a5f 
The current method of generating completions for the fish shell relies
on running `docker-compose --help`. On my system (a 2018 MacBook Pro)
this routinely takes several hundred milliseconds:

```
$ hyperfine --warmup 3 'docker-compose --help'
Benchmark docker#1: docker-compose --help
  Time (mean ± σ):     351.6 ms ±  16.0 ms    [User: 295.5 ms, System: 44.3 ms]
  Range (min … max):   332.8 ms … 384.0 ms    10 runs
```

If I configure fish to automatically load these completions, it makes
launching a new fish process very sluggish.

In addition, the regular expression used to parse the output of
`docker-compose --help` incorrectly generates completions for `name` and
`in` due to the following lines:

https://github.com/docker/compose/blob/9c5351cf27d10a7b8078496fb21a37929b6687cb/compose/cli/main.py#L208
https://github.com/docker/compose/blob/9c5351cf27d10a7b8078496fb21a37929b6687cb/compose/cli/main.py#L212

This commit fixes these issues by explicitly listing subcommands instead
of generating them dynamically. This means that adding/removing
subcommands won't automatically update the completions but according to
the git blame for `compose/cli/main.py`, no one has touched the list of
subcommands in the help message in 3+ years so I hope that won't be an
issue.

Signed-off-by: Collin Styles <collingstyles@gmail.com>
@vdo vdo mentioned this issue May 16, 2020
Closed
@KevinGhadyani-minted KevinGhadyani-minted mentioned this issue Jun 1, 2020
Closed
@fgauer fgauer mentioned this issue Jul 15, 2020
Closed
@mellester mellester mentioned this issue Mar 22, 2021
Closed
@cdalexndr cdalexndr mentioned this issue Aug 4, 2021
Closed
@Siah-All Siah-All mentioned this issue Oct 13, 2021
Closed
@dwalisson dwalisson mentioned this issue Nov 10, 2021
Closed
@bendodds bendodds mentioned this issue Dec 11, 2021
Closed
@RT-Tap RT-Tap mentioned this issue Dec 30, 2021
Closed
@Agosits Agosits mentioned this issue Mar 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop 'fig up' when a container exits docker/compose
1 participant
@bfirsh