Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop 'fig up' when a container exits #165

Merged
merged 1 commit into from
Mar 28, 2014
Merged

Stop 'fig up' when a container exits #165

merged 1 commit into from
Mar 28, 2014

Conversation

aanand
Copy link

@aanand aanand commented Mar 25, 2014

Closes #1 ヽ(*・ω・)ノ

Closes #1 ヽ(*・ω・)ノ
@bfirsh
Copy link

bfirsh commented Mar 26, 2014

Raise an exception instead maybe?

@aanand
Copy link
Author

aanand commented Mar 26, 2014

Exceptions across threads is complicated :(

screen shot 2014-03-26 at 17 53 25

Unless there's a way to multiplex several generators into one without threading, I don't know that this can be beaten for simplicity.

@bfirsh
Copy link

bfirsh commented Mar 28, 2014

no 1 121213

bfirsh added a commit that referenced this pull request Mar 28, 2014
Stop 'fig up' when a container exits
@bfirsh bfirsh merged commit 23a8938 into master Mar 28, 2014
@bfirsh bfirsh deleted the number-one branch March 28, 2014 23:03
yuval-k pushed a commit to yuval-k/compose that referenced this pull request Apr 10, 2015
Stop 'fig up' when a container exits
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fig up and attach should exit when processes exit
2 participants