-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old documentation source, add README on migration #1985
Conversation
The build error is unrelated to this change and can be ignored. |
Can we keep all of |
@dmcgowan Absolutely! Let me update the PR |
@RichardScothern @dmcgowan spec is back. :) |
@RichardScothern @dmcgowan Signed! Also; can I remove spec/api.md.tmpl from our repo if you're keeping it over here? |
23c24bf
to
abafe34
Compare
@johndmulhausen spec/api.md.tmpl is not human consumable document so it should not be in the docs repository |
LGTM |
Deleting per comments in distribution/distribution#1985
@RichardScothern Thanks! Removed api.md.tmpl in the docs repo. |
Should the reference doc We may want to have a top-level spec directory for the specification content. Will these be moved over to the new repo preserving history? |
Yes, the history was preserved. If additional things need to be excluded from the PR, I'll carry it since @johndmulhausen is on vacation. |
Signed-off-by: John Mulhausen <john@docker.com>
Signed-off-by: Misty Stanley-Jones <misty@docker.com>
@stevvooe @RichardScothern @dmcgowan PTAL again. I squashed John's commits and added back the |
Current coverage is 50.88% (diff: 100%)@@ master #1985 diff @@
==========================================
Files 125 125
Lines 11136 11136
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 6795 5666 -1129
- Misses 3453 4723 +1270
+ Partials 888 747 -141
|
LGTM I'm still not sure that we should move the storage driver docs. They are very much implementation specific and keeping them in sync has been hard enough with them in the same repo. I really think we need a better division between what is reference material vs what are downstream docs. |
LGTM. I can see arguments for keeping them, and also for moving them with the other docs. Let's just leave this as-is and as maintainers we'll be mindful to ensure any code changes which require documenting include a PR to the docs branch. |
Deleting per comments in distribution#1985
Deleting per comments in distribution#1985
Deleting per comments in distribution#1985
For more information on this migration, see https://blog.docker.com/2016/09/announcing-new-docs-repo-github/
Signed-off-by: John Mulhausen john@docker.com