use python3.6+ constructs #2863
Merged
+524
−658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anthony Sottile <asottile@umich.edu>
alesgenova
added a commit
to OpenChemistry/oremda
that referenced
this pull request
Jul 23, 2021
Should be fixed in the next release: docker/docker-py#2863
|
Hey @ulyssessouza, @aiordache. Do you know when's the next release that will contain this fix? |
|
It's great to see this Pull Request merged into master, but it would be even nicer to release it as version 5.0.1 and then yank 5.0.0 from PyPI. |
awkspace
added a commit
to awkspace/runfile
that referenced
this pull request
Aug 25, 2021
StevenMaude
added a commit
to opensafely-core/ehrql
that referenced
this pull request
Dec 1, 2022
It shouldn't be required following this Docker change: docker/docker-py#2863 That fix was included in `docker==5.0.1` and we're on 6.0.1 at the moment. We have no need for an explicit `six` dependency otherwise: Data Builder is Python 3 only.
StevenMaude
added a commit
to opensafely-core/ehrql
that referenced
this pull request
Dec 1, 2022
It shouldn't be required following this Docker change: docker/docker-py#2863 That fix was included in `docker==5.0.1` and we're on 6.0.1 at the moment. We have no need for an explicit `six` dependency otherwise: Data Builder is Python 3 only. However, `six` is still included as a transitive dependency of other packages.
StevenMaude
added a commit
to opensafely-core/ehrql
that referenced
this pull request
Dec 1, 2022
It shouldn't be required following this Docker change: docker/docker-py#2863 That fix was included in `docker==5.0.1` and we're on 6.0.1 at the moment. We have no need for an explicit `six` dependency otherwise: Data Builder is Python 3 only. However, `six` is still included as a transitive dependency of other packages.
Galaxy102
added a commit
to Galaxy102/docker-autocompose
that referenced
this pull request
Nov 13, 2024
six is no longer necessary as of docker-py 5.0.1 (see docker/docker-py#2863)
Galaxy102
added a commit
to Galaxy102/docker-autocompose
that referenced
this pull request
Nov 13, 2024
six is no longer necessary as of docker-py 5.0.1 (see docker/docker-py#2863)
Red5d
pushed a commit
to Red5d/docker-autocompose
that referenced
this pull request
Nov 13, 2024
* Translate setup.py to pyproject.toml * Introduce PEP518 by using Poetry as package manager * Introduce PEP402-ish package structure * Remove requirements.txt and setup.py * Update Dockerfile and Docs for new packaging method * Bump dependencies, remove six six is no longer necessary as of docker-py 5.0.1 (see docker/docker-py#2863)
jauderho
pushed a commit
to jauderho/docker-autocompose
that referenced
this pull request
Dec 22, 2024
* Translate setup.py to pyproject.toml * Introduce PEP518 by using Poetry as package manager * Introduce PEP402-ish package structure * Remove requirements.txt and setup.py * Update Dockerfile and Docs for new packaging method * Bump dependencies, remove six six is no longer necessary as of docker-py 5.0.1 (see docker/docker-py#2863) Signed-off-by: Jauder Ho <jauderho@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2842
I originally found that installing
pip install dockerwas broken becausesixis missing as a dependency -- but sincedocker-pyis python3.6+ there's really no reason to continue to usesixso what I did is I ran pyupgrade against docker-py and then I fixed the few things that
flake8pointed out afterwardsthis should "officially" drop the python-2 compatibility and use python3.6+-only constructs