change code to clarify logic #12432
Merged
change code to clarify logic #12432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mashimiao
force-pushed
the
optimize-code-to-clarify-loagic
branch
from
a2f4e66
to
799e391
Compare
Mashimiao
force-pushed
the
optimize-code-to-clarify-loagic
branch
from
799e391
to
0afbf95
Compare
Mashimiao
force-pushed
the
optimize-code-to-clarify-loagic
branch
from
0afbf95
to
616b557
Compare
Mashimiao
force-pushed
the
optimize-code-to-clarify-loagic
branch
from
616b557
to
aee5dbb
Compare
Mashimiao
changed the title
|
Seems not necessary if we have only one caller, I did the same thing in another PR:#11442 because we have two callers by then. But +1 if this can be merged first. |
|
@hqhq Ah... I did not know your PR has contained the similar changes. |
Mashimiao
force-pushed
the
optimize-code-to-clarify-loagic
branch
from
aee5dbb
to
ba08b6c
Compare
Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com>
Mashimiao
force-pushed
the
optimize-code-to-clarify-loagic
branch
from
ba08b6c
to
93cdb00
Compare
|
LGTM |
|
ping @LK4D4 , @icecrime , @jfrazelle |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ma Shimiao mashimiao.fnst@cn.fujitsu.com