Fix docker create with duplicate volume failed to remove

[coolljt0725]

*- What I did
fix #22093
- How I did it
During the registerMountPoints on container creation, it could be some volumes register
successfully but some failed, this will cause the container failed but with some volumes has
reference to this container, and these volume can't be remove.
The fix is to remove the mountpoints once registerMountPoints return failed.

- How to verify it
see #22093

- A picture of a cute animal (not mandatory but encouraged)

[lowenna]

WindowsTP5 failure on TestRunNoDupVolume appears legitimate. Probably because volumes are case insensitive on Windows. https://github.com/docker/docker/blob/master/volume/volume_windows.go#L95

[thaJeztah]

@jhowardmsft beat me to it :D

https://jenkins.dockerproject.org/job/Docker-PRs-WoW-TP5/733/console

02:15:44 ----------------------------------------------------------------------
02:15:44 FAIL: docker_cli_run_test.go:506: DockerSuite.TestRunNoDupVolumes
02:15:44 
02:15:44 docker_cli_run_test.go:540:
02:15:44     dockerCmd(c, "volume", "rm", mountstr1)
02:15:44 C:/gopath/src/github.com/docker/docker/pkg/integration/dockerCmd_utils.go:42:
02:15:44     c.Assert(err, check.IsNil, check.Commentf(quote+"%v"+quote+" failed with errors: %s, %v", strings.Join(args, " "), out, err))
02:15:44 ... value *exec.ExitError = &exec.ExitError{ProcessState:(*os.ProcessState)(0xc082250080)} ("exit status 1")
02:15:44 ... "volume rm D:\CI\CI-875e135\test1.QohZOUPDrq:c:\someplace" failed with errors: Error response from daemon: get d:\ci\ci-875e135\test1.qohzoupdrq:c:\someplace: no such volume
02:15:44 , exit status 1
02:15:44 
02:15:45 

[cpuguy83]

no need to check len on mountPoints since it's a range

I also think this may be too deep in the stack. I'd expect the caller to unwind this on error (and use https://github.com/docker/docker/blob/master/daemon/mounts.go#L20)

[coolljt0725]

@cpuguy83 if registerMountPoints returns error, the mountpoints which has been registered in registerMountPoints would not in container.MountPoint, the caller unwind this on error in https://github.com/docker/docker/blob/master/daemon/create.go#L107 based on container.MountPoint

yup, len is duplicate here

[thaJeztah]

Oh, looks like Windows is failing;

11:24:15 ----------------------------------------------------------------------
11:24:15 FAIL: docker_cli_run_test.go:506: DockerSuite.TestRunNoDupVolumes
11:24:15 
11:24:15 docker_cli_run_test.go:540:
11:24:15     dockerCmd(c, "volume", "rm", mountstr2)
11:24:15 C:/gopath/src/github.com/docker/docker/pkg/integration/dockerCmd_utils.go:42:
11:24:15     c.Assert(err, check.IsNil, check.Commentf(quote+"%v"+quote+" failed with errors: %s, %v", strings.Join(args, " "), out, err))
11:24:15 ... value *exec.ExitError = &exec.ExitError{ProcessState:(*os.ProcessState)(0xc08231c260)} ("exit status 1")
11:24:15 ... "volume rm D:\CI\CI-ba7c24c\test2.aIuQBeHSfr:c:\someplace" failed with errors: Error response from daemon: get d:\ci\ci-ba7c24c\test2.aiuqbehsfr:c:\someplace: no such volume
11:24:15 , exit status 1
11:24:15 

[LK4D4]

ping @coolljt0725

[coolljt0725]

@LK4D4 @thaJeztah really sorry for the late response, it's very busy these days and miss the github notes. updated.

[thaJeztah]

tested this and works for me LGTM

ping @vdemeester @runcom PTAL

[runcom]

LGTM

[vdemeester]

LGTM 🐸