Un-deprecated command line short variant options of -c
#22621
Conversation
| @@ -661,7 +661,7 @@ container: | |||
| | `--memory-swap=""` | Total memory limit (memory + swap, format: `<number>[<unit>]`). Number is a positive integer. Unit can be one of `b`, `k`, `m`, or `g`. | | |||
| | `--memory-reservation=""` | Memory soft limit (format: `<number>[<unit>]`). Number is a positive integer. Unit can be one of `b`, `k`, `m`, or `g`. | | |||
| | `--kernel-memory=""` | Kernel memory limit (format: `<number>[<unit>]`). Number is a positive integer. Unit can be one of `b`, `k`, `m`, or `g`. Minimum is 4M. | | |||
| | `-c`, `--cpu-shares=0` | CPU shares (relative weight) | | |||
| | `--cpu-shares=0` | CPU shares (relative weight) | | |||
There was a problem hiding this comment.
nit: can you re-align the | here?
There was a problem hiding this comment.
Thanks @thaJeztah I just updated the PR.
thaJeztah
added
status/2-code-review
impact/changelog
impact/deprecation
and removed
status/0-triage
labels
|
LGTM, thanks! |
|
LGTM (besides @thaJeztah's nit) |
|
:( I don't think this is a good idea. |
yongtang
force-pushed
the
05092016-remove-deprecated-command-line-short-variant-options
branch
from
bd12bbd
to
8954b72
Compare
|
@runcom @cpuguy83 @thaJeztah Thanks for the review. Let me know if we want to un-deprecate this option so that I could update the PR. |
|
If @cpuguy83 doesn't like it, then probably we shouldn't do it :/ |
|
Had a quick chat with @cpuguy83 and he mentioned seeing a lot of people still using the shorthand @yongtang can you update the PR to un-deprecate? |
Since 1.9, the following short variant options have been deprecated in favor of their long variants: `docker run -c (--cpu-shares)` `docker build -c (--cpu-shares)` `docker create -c (--cpu-shares)` `docker update -c (--cpu-shares)` However, `-c` is still widely used and is considered as a convenient option for swarm (see moby#16271). This fix undeprecated the command line short variant options of `-c` and updated the deprecated.md. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
yongtang
force-pushed
the
05092016-remove-deprecated-command-line-short-variant-options
branch
from
8954b72
to
fea7acf
Compare
yongtang
changed the title
-c
|
Thanks @thaJeztah. The pull request has been updated. Let me know if there are any issues. Note: I also updated the comment and title section of this pull request. |
|
LGTM, thanks @yongtang |
|
LGTM |
|
docs LGTM as well. Merging |
yongtang
deleted the
05092016-remove-deprecated-command-line-short-variant-options
branch
Since 1.9, the following short variant options have been deprecated in favor of their long variants:
docker run -c (--cpu-shares)docker build -c (--cpu-shares)docker create -c (--cpu-shares)docker update -c (--cpu-shares)However,
-cis still widely used and is considered as a convenient option for swarm (see #16271).This fix undeprecated the command line short variant options of
-cand updated the deprecated.md.Signed-off-by: Yong Tang yong.tang.github@outlook.com