Dockerd: enable CORS when only --api-cors-header is used
#32174
Conversation
Even though the flag `--api-enable-cors` is deprecated in favor of `--api-cors-header`. Using only `--api-cors-header` does not enable CORS. Make changes to 'cmd/dockerd/daemon.go' to enable cors if either of the above flags is set. Signed-off-by: Karthik Nayak <Karthik.188@gmail.com>
There was a problem hiding this comment.
Thanks! LGTM
I looked through the code, and I see this flag was deprecated a long time ago (Docker 1.6); #10586, at which point there was no "official" deprecation policy, so it's not mentioned in https://github.com/docker/docker/blob/master/docs/deprecated.md.
Would you be interested in doing a follow-up to add it to the "deprecated.md" file? We usually keep a 3 "stable" release deprecation cycle, but in this case, I think we should be ok with actually removing it in docker 17.09
There was a problem hiding this comment.
Thanks! LGTM
I looked through the code, and I see this flag was deprecated a long time ago (Docker 1.6); #10586, at which point there was no "official" deprecation policy, so it's not mentioned in https://github.com/docker/docker/blob/master/docs/deprecated.md.
Would you be interested in doing a follow-up to add it to the "deprecated.md" file? We usually keep a 3 "stable" release deprecation cycle, but in this case, I think we should be ok with actually removing it in docker 17.09
|
oh, sorry for the double post, I got an "angry unicorn" at GitHub |
|
Sure I'll do that, Should I push to the same branch (That would show up in this PR) or a new branch/PR? |
|
the deprecation is best done in a separate PR to not block this one; it may need a short discussion (of everyone agrees on the deprecation cycle - perhaps they're all ok with removing it directly) |
|
LGTM 👍 |
|
whoop, thanks @KarthikNayak 🎉!
|
Even though the flag
--api-enable-corsis deprecated in favor of--api-cors-header. Using only--api-cors-headerdoes not enableCORS.
Make changes to 'cmd/dockerd/daemon.go' to enable CORS if either of
the above flags is set.
Signed-off-by: Karthik Nayak Karthik.188@gmail.com
This PR closes the issue #32113
- What I did
Fixed the issue mentioned above.
- How I did it
Allowed CORS to be enabled even if
--api-enable-corsis not used but--api-cors-headeris set, by changing theifcondition incmd/dockerd/daemon.go.- How to verify it
Check issue for steps to reproduce and test.
- Description for the changelog
Fix an issue where CORS (
--api-cors-header) was ignored if--api-enable-corswas not set- A picture of a cute animal (not mandatory but encouraged)
Img Credit