This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
[19.03 backport] Move GOPATH out from under the GO source tree #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike Linux which uses a temp dir as GOPATH, Windows uses c:\go. Among other things, this blocks go get. Moving GOPATH to c:\gopath and updating references in comments and documentation. Currently the change is being scoped narrowly. In the future GOPATH value could be passed as a parameter to the ps1 scripts. Signed-off-by: Vikram bir Singh <vikrambir.singh@docker.com> (cherry picked from commit ecf91f0) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
deleted the
19.03_backport_move_windows_gopath_out_of_goroot
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of moby#39888
Unlike Linux which uses a temp dir as GOPATH, Windows
uses c:\go. Among other things, this blocks go get.
Moving GOPATH to c:\gopath and updating references in
comments and documentation.
Currently the change is being scoped narrowly. In the
future GOPATH value could be passed as a parameter to
the ps1 scripts.