WIP [18.09 backport] Bump swarmkit to a84c01f

[thaJeztah]

18.09 backports of:

• vendor: update swarmkit to 9f271c2 and remove boltdb moby/moby#37906 - slightly ahead of [18.09] Remove boltdb dependency #60. Full diff: moby/swarmkit@3044c57...9f271c2
  • Adding support for swap settings moby/swarmkit#2747 Adding support for swap settings (adds this feature to swarmkit, but is not exposed through the Docker API, so not functional changes)
  • Switch to go 1.11 moby/swarmkit#2752 Switch to go 1.11 (no code changes, other than formatting changes to match go 1.11)
• Bump swarmkit to 7d5d33b97794440462a04acdd3f31914da8f66f3 moby/moby#38024 full diff: moby/swarmkit@9f271c2...7d5d33b
  • Handle an edge case in CA rotation where we reclaim CA service from an external CA moby/swarmkit#2681 Handle an edge case in CA rotation where we reclaim CA service from an external CA
  • Use gometalinter; switch from x/net/context -> context moby/swarmkit#2750 Use gometalinter; switch from x/net/context -> context
• Bump swarmkit to a84c01f49091167dd086c26b45dc18b38d52e4d9 moby/moby#38056 full diff: moby/swarmkit@9f271c2...7d5d33b
  • Fix nil pointer dereference in node allocation moby/swarmkit#2764 Fix nil pointer dereference in node allocation
  • Added support for maximum replicas per node moby/swarmkit#2758 Added support for maximum replicas per node
  • Increased wait time on test utils WaitForCluster and WatchTaskCreate moby/swarmkit#2762 Increased wait time on test utils WaitForCluster and WatchTaskCreate

git checkout -b 18.09_backport_vndr ce-engine/18.09
git cherry-pick -s -S -x 82388d048a7f55fbcca05140bdfd747099b351c1
git cherry-pick -s -S -x 8dedcb8c516b914157d8274d5e94f0b8660cb866
git cherry-pick -s -S -x 93e1c5a5b73b80bee1ffc6b73b45fd304903dcc6
git push -u origin

conflict in vendor.conf in first commit, due to #60, which is not upstream

[thaJeztah]

ping @anshulpundir @dperny PTAL

[mavenugo]

@thaJeztah why are we pulling in all the changes in 18.09 bump ? Shouldnt we target the patches based on severity given 18.09 is in Beta phase ?

[thaJeztah]

@mavenugo let me defer that to @anshulpundir @dperny there's no 18.09 branch yet for swarmkit, looking at the changes;

• Handle an edge case in CA rotation where we reclaim CA service from an external CA moby/swarmkit#2681 would have to be triaged, but may actually be desirable for enterprise customers
• Use gometalinter; switch from x/net/context -> context moby/swarmkit#2750 is not critical, but will minimise risk on conflicts on future backports (no risk involved: effectively removing an alias/wrapper for an obsolete package)
• Switch to go 1.11 moby/swarmkit#2752 is only whitespace changes, no risk involved, but will minimise risk on conflicts on future backports
• Increased wait time on test utils WaitForCluster and WatchTaskCreate moby/swarmkit#2762 doesn't affect vendored code
• Added support for maximum replicas per node moby/swarmkit#2758 may need double-checking, but isn't exposed through the docker API, therefore won't affect swarmkit functionality

[anshulpundir]

#89 (comment) looks good. I agree with @thaJeztah

cc @dperny

[andrewhsu]

LGTM

[andrewhsu]

was told by @anshulpundir that moby/swarmkit#2768 is in works that could reduce the changeset to pull into the engine 18.09 codeline

[thaJeztah]

Closing in favor of #94