Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17.03.1-ce.... format doesn't follow http://semver.org/ causing breaks #1491

Closed
schultz9999 opened this issue Mar 30, 2017 · 4 comments
Closed

Comments

@schultz9999
Copy link

schultz9999 commented Mar 30, 2017

Expected behavior

Version is to follow http://semver.org/ rules.

Actual behavior

03 in minor doesn't follow the expected format required by semantic version.

  File "/usr/local/lib/python2.7/site-packages/dockerman/__init__.py", line 931, in docker_version
    return semantic_version.Version.coerce(c.version()['Version'], partial=True)
  File "/usr/local/lib/python2.7/site-packages/semantic_version/base.py", line 183, in coerce
    return cls(version, partial=partial)
  File "/usr/local/lib/python2.7/site-packages/semantic_version/base.py", line 77, in __init__
    major, minor, patch, prerelease, build = self.parse(version_string, partial)
  File "/usr/local/lib/python2.7/site-packages/semantic_version/base.py", line 212, in parse
    raise ValueError("Invalid leading zero in minor: %r" % version_string)
ValueError: Invalid leading zero in minor: u'17.03.1-ce'

Information

  • Full output of the diagnostics from "Diagnose & Feedback" in the menu
  • A reproducible case if this is a bug, Dockerfiles FTW
  • Page URL if this is a docs issue or the name of a man page

Steps to reproduce the behavior

Try to validate the version with Python's semantic_version library.

@schultz9999 schultz9999 changed the title 17.03.1-ce.... 17.03.1-ce.... format doesn't follow http://semver.org/ causing breaks Mar 30, 2017
@avsm
Copy link

avsm commented Mar 31, 2017

Thanks for the bug report. This isn't directly a Docker for Mac bug, as the app follows the upstream Docker versioning conventions (with a -mac suffix to indicate its local epoch).

Docker doesn't currently use semantic versioning, but there is a proposal for switching to it in moby/moby#31842. Once that discussion has concluded and is merged into Docker upstream, the Mac version here will follow. Please do register feedback on that issue, such as your desire for py-semantic_version compatibility.

@avsm avsm closed this as completed Mar 31, 2017
@ijc
Copy link
Contributor

ijc commented Mar 31, 2017

To be clear, moby/moby#31842 is proposing the use of semver for the ReST API, which is independent from the docker version. AFAIK the docker versions have never been semver, lots of projects use 3 integers separated by a . without it being semver.

@schultz9999
Copy link
Author

schultz9999 commented Mar 31, 2017

We didn't have any issues before this update. For example, I dug out 1.13.1 and things are good. I can't say if it's docker or API version problem. Considering that the autoupdate is generally enabled and it's very hard to download previous releases, I can see this to give many headaches.

Speaking of older versions, do you mind sharing a couple URLs for versions that have no '0' in MINOR? I was not able to composite one based on the suggestions in #1120.

@docker-robott
Copy link
Collaborator

Closed issues are locked after 30 days of inactivity.
This helps our team focus on active issues.

If you have found a problem that seems similar to this, please open a new issue.

Send feedback to Docker Community Slack channels #docker-for-mac or #docker-for-windows.
/lifecycle locked

@docker docker locked and limited conversation to collaborators Jun 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants