Skip to content
This repository has been archived by the owner on Jun 16, 2021. It is now read-only.

Proposal : Enable golint on the code base #14

Closed
11 tasks done
vdemeester opened this issue Aug 13, 2015 · 4 comments
Closed
11 tasks done

Proposal : Enable golint on the code base #14

vdemeester opened this issue Aug 13, 2015 · 4 comments

Comments

@vdemeester
Copy link
Collaborator

Taking the description directly from docker#14756.

We want to enable golint on our codebase for several reasons:

  • We want to improve code quality
  • We need objective filters on quality to help us discriminate bad pull requests

There is some work to do, but I think it's would be better to do it as early as possible (easier to do). And as libcompose is intended to be used as a library more than just a cli, documentation and quality is import I think.

WDYT about that ?
If you think we should do it, we'll keep track of the work on this issue then 😉.

Package (and linting status) :
@dave-tucker
Copy link
Contributor

👍 we should probably go vet too
http://goreportcard.com/report/docker/libcompose

@ibuildthecloud
Copy link
Contributor

Both would be awesome. Always better now than later. @dave-tucker I had no idea that goreportcard site existed. That is cool.

@vdemeester
Copy link
Collaborator Author

@dave-tucker yeah me neither, pretty cool site 😊.

I'll setup the golint and govet validation the way there setup in docker and we'll have then have time to cover package as we go then 😉.

vdemeester added a commit to vdemeester/libcompose that referenced this issue Aug 13, 2015
@vdemeester
Setup validate-golint
a16868e 
- Add a validate-lint target (and script/validate-lint that does the
  job)
- Add the first package that is covered by it : version.

Related to docker#14
vdemeester added a commit to vdemeester/libcompose that referenced this issue Aug 13, 2015
@vdemeester
Setup validate-golint
311ee4e 
- Add a validate-lint target (and script/validate-lint that does the
  job)
- Add the first package that is covered by it : version.

Related to docker#14

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@vdemeester vdemeester mentioned this issue Aug 13, 2015
Merged
vdemeester added a commit to vdemeester/libcompose that referenced this issue Aug 13, 2015
@vdemeester
Setup validate-golint
86e4865 
- Add a validate-lint target (and script/validate-lint that does the
  job)
- Add the first package that is covered by it : version.

Related to docker#14

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester added a commit to vdemeester/libcompose that referenced this issue Aug 13, 2015
@vdemeester
Setup validate-vet
0e05a4b 
- Add a validate-vet target (and script/validate-vet that does the
  job)

Related to docker#14

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester added a commit to vdemeester/libcompose that referenced this issue Aug 13, 2015
@vdemeester
Setup validate-vet
3176705 
- Add a validate-vet target (and script/validate-vet that does the
  job)

Related to docker#14

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@vdemeester vdemeester mentioned this issue Aug 13, 2015
Merged
vdemeester added a commit to vdemeester/libcompose that referenced this issue Aug 13, 2015
@vdemeester
Setup validate-golint
4d957e0 
- Add a validate-lint target (and script/validate-lint that does the
  job)
- Add the first package that is covered by it : version.

Related to docker#14

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester added a commit to vdemeester/libcompose that referenced this issue Aug 13, 2015
@vdemeester
Setup validate-golint
a18441b 
- Add a validate-lint target (and script/validate-lint that does the
  job)
- Add the first package that is covered by it : version.

Related to docker#14

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester added a commit to vdemeester/libcompose that referenced this issue Aug 13, 2015
@vdemeester
Setup validate-vet
7ded83f 
- Add a validate-vet target (and script/validate-vet that does the
  job)

Related to docker#14

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester added a commit to vdemeester/libcompose that referenced this issue Aug 13, 2015
@vdemeester
Setup validate-golint
6b61664 
- Add a validate-lint target (and script/validate-lint that does the
  job)
- Add the first package that is covered by it : version.

Related to docker#14

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester added a commit to vdemeester/libcompose that referenced this issue Aug 13, 2015
@vdemeester
Setup validate-vet
599216f 
- Add a validate-vet target (and script/validate-vet that does the
  job)

Related to docker#14

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester added a commit to vdemeester/libcompose that referenced this issue Aug 13, 2015
@vdemeester
Setup validate-golint
f8bbd68 
- Add a validate-lint target (and script/validate-lint that does the
  job)
- Add the first package that is covered by it : version.

Related to docker#14

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester added a commit to vdemeester/libcompose that referenced this issue Aug 13, 2015
@vdemeester
Setup validate-golint
8a73edb 
- Add a validate-lint target (and script/validate-lint that does the
  job)
- Add the first package that is covered by it : version.

Related to docker#14

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester added a commit to vdemeester/libcompose that referenced this issue Aug 13, 2015
@vdemeester
Setup validate-vet
1876138 
- Add a validate-vet target (and script/validate-vet that does the
  job)

Related to docker#14

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester added a commit to vdemeester/libcompose that referenced this issue Aug 23, 2015
@vdemeester
Setup validate-golint
c94153c 
- Add a validate-lint target (and script/validate-lint that does the
  job)
- Add the first package that is covered by it : version.
- Micro diff on lookup to make it linted

Related to docker#14

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester added a commit to vdemeester/libcompose that referenced this issue Aug 23, 2015
@vdemeester
Setup validate-vet
c7477ae 
- Add a validate-vet target (and script/validate-vet that does the
  job)

Related to docker#14

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@gdevillele
Copy link
Contributor

goreportcard looks awesome! 👍
Thank you.

vdemeester added a commit to vdemeester/libcompose that referenced this issue Aug 28, 2015
@vdemeester
Setup validate-vet
7deff07 
- Add a validate-vet target (and script/validate-vet that does the
  job)

Related to docker#14

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester added a commit to vdemeester/libcompose that referenced this issue Aug 28, 2015
@vdemeester
Setup validate-vet
c9d2dc3 
- Add a validate-vet target (and script/validate-vet that does the
  job)

Related to docker#14

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@vdemeester vdemeester mentioned this issue Sep 29, 2015
Merged
yudai added a commit to yudai/libcompose that referenced this issue Feb 3, 2017
@yudai
Merge pull request docker#14 from cloudwan/authp
a1ca510 
Merge authproxy fixes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vdemeester @gdevillele @ibuildthecloud @dave-tucker