This repository has been archived by the owner on Jun 16, 2021. It is now read-only.
Linting cli package
#31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,10 +8,12 @@ import ( | |||
| "github.com/docker/libcompose/project" | |||
| ) | |||
|
|
|||
| type ProjectFactory struct { | |||
| // DockerProjectFactory is a struct that hold the app.ProjectFactory implementation. | |||
| type DockerProjectFactory struct { | |||
There was a problem hiding this comment.
I renamed that as it felt a little weird to have the exact same name for the interface and the struct implementing it. If it breaks outside uses of the lib, tell me, I'll revert that change.
There was a problem hiding this comment.
It's pretty common in go to do this because any time you reference the type you also include package. So calling code would look like dockerApp.ProjectFactory. Making the type have the package name in it then makes it redundant dockerApp.DockerProjectFactory.
There was a problem hiding this comment.
Oh.. I didn't see it like that. I'll revert this one, agre with you, it makes it redundant.
|
@ibuildthecloud Updated according to your comments 馃槈. |
11 tasks
packages: cli/app, cli/command, cli/docker/app, cli/logger, cli/main Signed-off-by: Vincent Demeester <vincent@sbr.pm>
|
LGTM 馃憤 |
|
LGTM |
|
馃帀 馃槈 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated packages:
cli/app,cli/command,cli/docker/app,cli/logger,cli/main.Wating for #21 to be merged but that opens it to reviews already 馃槈.
馃惛
Signed-off-by: Vincent Demeester vincent@sbr.pm