This repository has been archived by the owner on Sep 26, 2021. It is now read-only.
Migrate 'amazonec2' driver to AWS SDK #2684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does an almost 1-to-1 translation of API calls. The differences are as follows: 1. Use the SDK waiter for spot instance request fulfillment 2. Uses the toplevel private/public ip fields instead of the networkinterface's fields 3. Recognizes the 'Terminated' state as an error explicitly instead of implicitly. 4. Uses filters on DescribeSecurityGroups to find the correct one more efficiently and to limit to a given VPC. Other than that, it really should be identical apart from the perhaps obvious error message differences. Signed-off-by: Euan <euank@euank.com>
Signed-off-by: Euan <euank@euank.com>
Deprecated by the conversion to the upstream SDK Signed-off-by: Euan <euank@euank.com>
Signed-off-by: Jean-Laurent de Morlhon <jeanlaurent@morlhon.net>
|
@jeanlaurent @euank Will review it on Monday |
|
Your additional change LGTM. Thanks! I would have been happy to make those changes if you asked on my PR, but this works as well. |
|
@euank I wanted this PR to go with the next release ( next Monday ). And wasn't that comfortable to ask for a quick rebase, considering this is holiday time & we didn't find the time before to handle your PR. But good to know. I believe there is quite a bunch of PR enhancing the ec2 drivers that will be impacted. |
|
LGTM |
dgageot
added a commit
that referenced
this pull request
Dec 28, 2015
Migrate 'amazonec2' driver to AWS SDK
This was referenced Jan 4, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes the PR #1850 from @euank and rebase it on current master. ( fixes #858 )
Oh, btw this fixes #1571 as restart is now properly handled.
This is an LGTM on @euank commits. I added a cleanup commit, which I let @docker/machine-maintainers appreciate.