This repository has been archived by the owner on Sep 26, 2021. It is now read-only.
Fix amazonec2 initiated shutdown caused by constant DeviceName #2640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @pottava for your contribution. Can you update the driver documentation also? |
|
@dgageot Thanks for your review. Updated! |
|
Thanks a lot @pottava Can you please squash your commits to make the review easier? |
|
@dgageot I'm not used to this kind of workflow, sorry about that. I hope my push worked properly. |
|
Thank you @pottava. Please squash the two commits and then it's good to go! |
|
Can you check again, @dgageot ? Thank you for your help :) |
|
@pottava I just merged a huge refactoring on aws plugin. Can you rebase on master so that I can merge your PR today? Thanks a lot and sorry for the inconvenience. |
…sda1) Signed-off-by: ryo nakamaru <pottava@gmail.com>
|
LGTM |
dgageot
added a commit
that referenced
this pull request
Dec 28, 2015
…configurable Fix amazonec2 initiated shutdown caused by constant DeviceName
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to this document, root device must be /dev/xvda when we want to use HVM EBS-Backed instances with some AMIs. So Docker-Machine should be more configurable about BlockDeviceMapping on amazonec2 driver in order to launch more modern instance family like t2.nano.
I think this PR and user configurations might fix following issues.
refs #2317, #2222