un-fork coreos/etcd - bump to v3.2.1 #2296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 5d77af7 temporarily switch etcd to a fork, pending a pull-request to be merged, and a new release that contains the change. The pull request was merged, and included in etcd v3.2.0 This patch bumps etcd to v3.2.1, which contains some bug-fixes on top of v3.2.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report
@@ Coverage Diff @@
## master #2296 +/- ##
==========================================
+ Coverage 61.1% 61.12% +0.01%
==========================================
Files 128 128
Lines 20549 20549
==========================================
+ Hits 12557 12561 +4
- Misses 6607 6608 +1
+ Partials 1385 1380 -5 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #2296 +/- ##
==========================================
+ Coverage 61.1% 61.12% +0.01%
==========================================
Files 128 128
Lines 20549 20549
==========================================
+ Hits 12557 12561 +4
- Misses 6607 6608 +1
+ Partials 1385 1380 -5 |
nishanttotla
approved these changes
Jul 3, 2017
There was a problem hiding this comment.
LGTM
(let's wait for @aaronlehmann as well, we should confirm that there are no other side effects of bumping up)
|
agreed, definitely want him to have a look at this 👍 |
|
LGTM Normally I'm somewhat apprehensive about updating this dependency, since doing so has triggered bugs in the past. But these changes look minor and sensible. I think it's reasonable to update this as long as it's not happening just before a stable release. Could you please make a followup PR for moby/moby? |
andrewhsu
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Jul 14, 2017
- moby/swarmkit#2266 (support for templating Node.Hostname in docker executor) - moby/swarmkit#2281 (change restore action on objects to be update, not delete/create) - moby/swarmkit#2285 (extend watch queue with timeout and size limit) - moby/swarmkit#2253 (version-aware failure tracking in the scheduler) - moby/swarmkit#2275 (update containerd and port executor to container client library) - moby/swarmkit#2292 (rename some generic resources) - moby/swarmkit#2300 (limit the size of the external CA response) - moby/swarmkit#2301 (delete global tasks when the node running them is deleted) Minor cleanups, dependency bumps, and vendoring: - moby/swarmkit#2271 - moby/swarmkit#2279 - moby/swarmkit#2283 - moby/swarmkit#2282 - moby/swarmkit#2274 - moby/swarmkit#2296 (dependency bump of etcd, go-winio) Signed-off-by: Ying Li <ying.li@docker.com> Upstream-commit: 4509a00 Component: engine
silvin-lubecki
pushed a commit
to silvin-lubecki/engine-extract
that referenced
this pull request
Mar 16, 2020
- moby/swarmkit#2266 (support for templating Node.Hostname in docker executor) - moby/swarmkit#2281 (change restore action on objects to be update, not delete/create) - moby/swarmkit#2285 (extend watch queue with timeout and size limit) - moby/swarmkit#2253 (version-aware failure tracking in the scheduler) - moby/swarmkit#2275 (update containerd and port executor to container client library) - moby/swarmkit#2292 (rename some generic resources) - moby/swarmkit#2300 (limit the size of the external CA response) - moby/swarmkit#2301 (delete global tasks when the node running them is deleted) Minor cleanups, dependency bumps, and vendoring: - moby/swarmkit#2271 - moby/swarmkit#2279 - moby/swarmkit#2283 - moby/swarmkit#2282 - moby/swarmkit#2274 - moby/swarmkit#2296 (dependency bump of etcd, go-winio) Signed-off-by: Ying Li <ying.li@docker.com> Upstream-commit: 4509a00 Component: engine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 5d77af7 (#2158) temporarily switch etcd to a fork, pending a pull request (etcd-io/etcd#7830) to be merged, and a new release that contains the change.
The pull request was merged, and included in etcd v3.2.0
This patch bumps etcd to v3.2.1, which contains some bug-fixes on top of v3.2.0
ping @aaronlehmann @nishanttotla ptal