Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coder addon #47

Closed
wants to merge 3 commits into from
Closed

Coder addon #47

wants to merge 3 commits into from

Conversation

acondura
Copy link

@acondura acondura commented Sep 6, 2019

Coder addon using a fork of https://github.com/cdr/code-server, which fixes the "Insufficient permission" error on save.

@achekulaev
Copy link
Member

@lmakarov is it properly using the IDE option?

@acondura
Copy link
Author

I'll be applying a few more fixes this week and also test out the latest version 2 of code server which they say "uses the new web and remote functionality VS Code has implemented which has made it possible to shrink the code base by about a factor of ten. It should be much easier to upgrade VS Code versions now and it'll fix a decent number of issues." coder/code-server#857

@achekulaev
Copy link
Member

Keep us posted

@acondura
Copy link
Author

V2 of code-server (https://hub.docker.com/r/codercom/code-server/tags) indeed runs a bit smoother. I'm adding some finishing touches to the addon and I'll push an updated version this week.

@lmakarov
Copy link
Member

@lmakarov is it properly using the IDE option?

@achekulaev this addon and the stock IDE option in docksal/cli are not related.

@acondura the latest versions of docksal/cli (v2.9.0, just released) now ships with VS Code Server v1 (v2 does not work with xdebug) preinstalled.

Steps to enable the integration:

  1. Update to the latest dev version of Docksal
DOCKSAL_VERSION=develop fin update
  1. Update your project stack configuration
fin config set CLI_IMAGE=docksal/cli:2.9-php7.3
fin config set --env=local IDE_ENABLED=1
fin config set --env=local XDEBUG_ENABLED=1
fin project start

I recorded a quick video to demo the upcoming functionality:
https://youtu.be/3hHDoXlqeJ8

@acondura you are welcome to contribute to docksal/cli with further VS Code Server integration updates (e.g. updating to v2 and fixing xdebug).

@acondura
Copy link
Author

Niceeeee! Glad to hear it's in docksal/cli and that it's using the 'ide-' prefix.
I'll definitely look into v2 and xdebug.

@lmakarov
Copy link
Member

With VS Code bundled in docksal/cli, I don't see a need in the coder addon. Closing.

@lmakarov lmakarov closed this Oct 21, 2019
@acondura
Copy link
Author

@lmakarov Curious, I followed all the steps you listed and I constantly get:

Pulling cli (docksal/cli:2.9-ide)...
ERROR: manifest for docksal/cli:2.9-ide not found: manifest unknown: manifest unknown

@achekulaev
Copy link
Member

achekulaev commented Oct 22, 2019

@acondura you have older overrides-ide.yml stack file. You'll be able to test when we release RC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants