Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix security vulnerabilities #12

Closed
brainrecursion opened this issue Sep 19, 2018 · 1 comment · Fixed by #13
Closed

Fix security vulnerabilities #12

brainrecursion opened this issue Sep 19, 2018 · 1 comment · Fixed by #13

Comments

@brainrecursion
Copy link
Contributor

brainrecursion commented Sep 19, 2018 •
edited
Loading

  1. SQL injection - CVE-2018-17232
    When searching the archive user input is used directly to create an SQL query. This can be exploited to view all messages, including messages from private channels the user is not a member of. Potentially exploitable to gain Remote Code Execution (RCE) depending on the configuration of the server.

  2. Information disclosure.
    If a user searches for a phrase that has been posted in a private channel the user is not a member of, the bot returns nothing rather than "No results found". This leaks to the user that the phrase has been said.
@brainrecursion brainrecursion mentioned this issue Sep 19, 2018
Merged
@abergmann
Copy link

CVE-2018-17232 was assigned to that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for security vulnerabilities brainrecursion/slack-archive-bot
2 participants
@abergmann @brainrecursion