Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE: Supporting public shared spaces #46

Closed
cwang opened this issue Jul 4, 2023 · 6 comments
Closed

CORE: Supporting public shared spaces #46

cwang opened this issue Jul 4, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@cwang
Copy link
Contributor

cwang commented Jul 4, 2023

Is your feature request related to a problem? Please describe.

For #23 we need a different type of shared space where all data can be accessed by the general public.

Describe the solution you'd like

Shared spaces should be internal by default and the sharing is controlled by multi-user access as before. What's new is the new type of shared space for public use.

Describe alternatives you've considered

N/A

Additional context

On UI/UX make sure we distinguish this type of shared space enough from the conventional, internal shared space.

@cwang cwang added the enhancement New feature or request label Jul 4, 2023
@janaka
Copy link
Contributor

janaka commented Jul 4, 2023

Just to clarify, we are spliting the shared space type into something like 'internal shared' and 'public shared' (like with github enterprise repos) or handling purely via authZ?

@cwang
Copy link
Contributor Author

cwang commented Jul 5, 2023

Probably the latter - it is unlikely to justify to be a new space type and easier if we come up with a way to do it aligned with authz

@cwang cwang self-assigned this Jul 5, 2023
@janaka janaka added this to the First $10 MRR milestone Jul 12, 2023
@janaka
Copy link
Contributor

janaka commented Aug 7, 2023

@cwang can we get a status update on this issue. It's going to be blocking Jashon on #23 very soon.

@cwang
Copy link
Contributor Author

cwang commented Aug 7, 2023

Right now the permissions are not enforced so it shouldn't block #23, until the access control is in place which I will take care of later.

@janaka
Copy link
Contributor

janaka commented Sep 6, 2023

@cwang what are your plans for finishing this off?

@janaka
Copy link
Contributor

janaka commented Sep 27, 2023

@cwang I think this is all done now. can you confirm pls.

@janaka janaka closed this as completed Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants