Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After [filename](README.md ':include'), the docsify-tabs plugin in README.md fails #2000

Closed
1 task done
zhangkaiqiu opened this issue Mar 3, 2023 · 7 comments
Closed
1 task done

Comments

@zhangkaiqiu
Copy link

zhangkaiqiu commented Mar 3, 2023

Bug Report

Steps to reproduce

What is current behaviour

What is the expected behaviour

Other relevant information

  • Bug does still occur when all/other plugins are disabled?

  • Your OS:

  • Node.js version:

  • npm/yarn version:

  • Browser version:

  • Docsify version: <script src="//cdn.jsdelivr.net/npm/docsify/lib/docsify.min.js"></script>

  • Docsify plugins: docsify-tabs v1.6.0

Please create a reproducible sandbox

Edit 307qqv236

Mention the docsify version in which this bug was not present (if any)

@Koooooo-7
Copy link
Member

Hi @zhangkaiqiu , could plz provide more details about it? I checked the sandbox above. it does show the tabs.

@zhangkaiqiu
Copy link
Author

zhangkaiqiu commented Mar 7, 2023

I'm sorry I didn't describe clearly.

When I use the docsify-tab plugin normally, I expect the display to be as follows:
image
It is like the display effect of google browser tabs.

Its source code is as follows:

<!-- tabs:start -->

#### **English**

Hello!

#### **French**

Bonjour!

#### **Italian**

Ciao!

<!-- tabs:end -->

image

But when I apply it with include:
image
Its display effect is as follows:
image

@Koooooo-7
Copy link
Member

I see, you wanna use :include to get a tab from other md resource.
I m not quite sure whether docsify-tab supports it or not.

Hi @jhildenbiddle , could plz you take a look on this?

@jhildenbiddle
Copy link
Member

Plugins like docsify-tabs are unable to process embedded markdown content because docsify does not send embedded markdown through the plugin chain. Instead, docsify transforms markdown into HTML and makes that HTML available to plugins only within the afterEach hook.

@jhildenbiddle jhildenbiddle added enhancement and removed needs investigation plugin related to plugin stuff. labels Feb 15, 2024
@jhildenbiddle
Copy link
Member

Marking as duplicate of more appropriately named issue: #2373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants