[DCOM-118] fix for issue #195 #198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link: |
|
you have 23 commits becasuse you started your feature branch based on the 2.3 branch instead of master. git checkout doclexingfail
# save a reference to the current state of the feature branch
git branch tmp
# reset the feature branch to master
git fetch upstream
git reset --hard upstream/master
# cherry-pick the meaningful commit for the feature
git cherry-pick f1516fb
# IMPORTANT: at this point, check that the feature branch is working properly with your changes
# update the PR by forcing the push
git push origin doclexingfail --force |
|
and please also add a test for this |
…ithin quotes without a newline character
|
thx for the help, cherry pick was the command i didn't find. please read: |
| $reader = $this->getReader(); | ||
| $class = new ReflectionClass('Doctrine\Tests\Common\Annotations\Fixtures\ClassWithAtInDescriptionAndAnnotation'); | ||
|
|
||
| $this->assertEquals(1,count($fooAnnot = $reader->getPropertyAnnotations($class->getProperty('foo')))); |
There was a problem hiding this comment.
could you use assertCount here ?
and a space is missing after the comma
Ocramius
added a commit
to Ocramius/annotations
that referenced
this pull request
Dec 3, 2013
Ocramius
added a commit
to Ocramius/annotations
that referenced
this pull request
Dec 3, 2013
|
I ported this PR to doctrine/annotations#17 |
This was referenced Dec 6, 2015
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sorry, i have no idea why i got here now 23 commits .. i tried but no success.