-
-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDC-2160] Smart Pluralize/Singularize support for Doctrine/Common/Util/Inflector #227
Conversation
…e used in Doctrine/ORM/Tools/EntityGenerator to fix [DDC-2160] properly.
Hello, thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link: |
I am updating the pull request for Doctrine/ORM/Tools/EntityGenerator upstream to use this functionality |
} | ||
|
||
Inflector::reset(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove it. A file containing a class definition should contain only the class
…til/InflectorTest to follow coding standards
Awesome, can you change the protected to private? This class can reastically not be overwritten, lets not make people hopes :-) |
Done |
How about making this a dedicated composer package which we can just reference? There is no point in each project coming up with own inflectors, no? |
@schmittjoh the problem is, again, all the non-composer folks. |
@Ocramius, if they exists, let them voice their concern, but we cannot stay in the past forever. |
@schmittjoh I'm all for deprecating all that stuff, we are just forced to keep BC until 3.x. |
Regarding BC that should be easy here as these are all new features. |
@schmittjoh i haven't actually thought about this, i suppose a dedicated component for this would be pretty nice. I started an internal inquiry if we should drop PEAR support for 2.4 |
We will drop PEAR support for 2.4, and will start moving parts out of Common into their own subprojects. |
I will merge this for now, then start extracting it. |
[DDC-2160] Smart Pluralize/Singularize support for Doctrine/Common/Util/Inflector
That's great news! Thanks for the swift response. |
Doctrine/ORM/Tools/EntityGenerator should pluralize/signularize correctly.
This PR adds functionality to Doctrine/Common/Util/Inflector to singularize/pluralize. The code is largely borrowed from a similar class in the CakePHP project - I'm not sure if the updates to the class doc covers the requirements for this.
Test coverage also added.