[RFC] Load parent classes when loading metadata from cache #369
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be done more neatly, but before putting more time in it I'd like to check if it's a good idea.
I came across this solution because we had a problem with Gedmo extensions when caching metadata in Redis, this is our scenario:
Class B
has aGedmo extension
mapped field.On first request metadata for both
Class A
andClass B
is cached in Redis.On second request
AbstractClassMetadataFactory
loadsClass A
from Redis.Gedmo extension loops through all
Class A
parents and calls methodhasMetadataFor($parentClass)
inAbstractClassMetadataFactory
, onlyClass A
metadata has been loaded previously, thereforehasMetadataFor($parentClass)
returns false, andGedmo
then skips the parent class.Should Gedmo extension load the metadata for the parent class or should it be done as proposed in this PR?