[RFC] Load parent classes when loading metadata from cache #369
Conversation
This can be done more neatly, but before putting more time in it I'd like to check if it's a good idea. I came across this solution because we had a problem with Gedmo extensions when caching metadata in Redis, this is our scenario: ``` Class A extends B; ``` ``` ``Class B`` has a ``Gedmo`` mapped field. On first request metadata for both ``A`` and ``B`` is cached in Redis. On second request ``AbstractClassMetadataFactory`` loads ``Class A`` from Redis. Gedmo extension loops through all ``Class A`` parents and calls method ``hasMetadataFor($parentClass)`` in ``AbstractClassMetadataFactory``, only ``Class A`` metadata has been loaded previously, therefore ``hasMetadataFor($parentClass)`` returns false, and ``Gedmo`` then skips the parent class. Should Gedmo exension load the metadata for the parent class or should it be done as proposed in this PR?
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DCOM-287 We use Jira to track the state of pull requests and the versions they got |
|
|
No, it's not the order. So when this class saves to cache, it saves all parent classes too, but when it reads from cache, it only reads the class metadata, not it's parents, and that's what I'm doing here. |
|
ping |
|
Needs test scenario that validates the use-case (failing before patch) |
|
Hello, |
This can be done more neatly, but before putting more time in it I'd like to check if it's a good idea.
I came across this solution because we had a problem with Gedmo extensions when caching metadata in Redis, this is our scenario:
Class Bhas aGedmo extensionmapped field.On first request metadata for both
Class AandClass Bis cached in Redis.On second request
AbstractClassMetadataFactoryloadsClass Afrom Redis.Gedmo extension loops through all
Class Aparents and calls methodhasMetadataFor($parentClass)inAbstractClassMetadataFactory, onlyClass Ametadata has been loaded previously, thereforehasMetadataFor($parentClass)returns false, andGedmothen skips the parent class.Should Gedmo extension load the metadata for the parent class or should it be done as proposed in this PR?