Merge pull request #4519 from morozov/deprecate-connection-schema-man…

…ager

Deprecate Connection::$_schemaManager and Connection::getSchemaManager()

UPGRADE.md

@@ -1,5 +1,10 @@
 # Upgrade to 3.1
 
+## Deprecated `Connection::$_schemaManager` and `Connection::getSchemaManager()` 
+
+The usage of `Connection::$_schemaManager` and `Connection::getSchemaManager()` are deprecated.
+Use `Connection::createSchemaManager()` instead.
+
 ## Deprecated `Connection::$_expr`
 
 The usage of `Connection::$_expr` by extending classes is deprecated. Use `Connection::getExpressionBuilder()` instead.

src/Connection.php

@@ -129,6 +129,8 @@ class Connection
     /**
      * The schema manager.
      *
+     * @deprecated Use {@link createSchemaManager()} instead.
+     *
      * @var AbstractSchemaManager|null
      */
     protected $_schemaManager;
@@ -1502,21 +1504,34 @@ public function getWrappedConnection()
         return $this->_conn;
     }
 
+    /**
+     * Creates a SchemaManager that can be used to inspect or change the
+     * database schema through the connection.
+     *
+     * @throws Exception
+     */
+    public function createSchemaManager(): AbstractSchemaManager
+    {
+        return $this->_driver->getSchemaManager(
+            $this,
+            $this->getDatabasePlatform()
+        );
+    }
+
     /**
      * Gets the SchemaManager that can be used to inspect or change the
      * database schema through the connection.
      *
+     * @deprecated Use {@link createSchemaManager()} instead.
+     *
      * @return AbstractSchemaManager
      *
      * @throws Exception
      */
     public function getSchemaManager()
     {
         if ($this->_schemaManager === null) {
-            $this->_schemaManager = $this->_driver->getSchemaManager(
-                $this,
-                $this->getDatabasePlatform()
-            );
+            $this->_schemaManager = $this->createSchemaManager();
         }
 
         return $this->_schemaManager;