DDC-178 DQL Optimistic Lock now requires ALL classes to be versioned,…

… otherwise throws exception
doctrine · May 15, 2010 · ad402c6 · ad402c6
1 parent 1031249
commit ad402c6
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/lib/Doctrine/ORM/Query/SqlWalker.php b/lib/Doctrine/ORM/Query/SqlWalker.php
@@ -372,16 +372,11 @@ public function walkSelectStatement(AST\SelectStatement $AST)
             } else if ($lockMode == \Doctrine\DBAL\LockMode::PESSIMISTIC_WRITE) {
                 $sql .= " " . $this->_platform->getWriteLockSQL();
             } else if ($lockMode == \Doctrine\DBAL\LockMode::OPTIMISTIC) {
-                $versionedClassFound = false;
                 foreach ($this->_selectedClasses AS $class) {
-                    if ($class->isVersioned) {
-                        $versionedClassFound = true;
+                    if (!$class->isVersioned) {
+                        throw \Doctrine\ORM\OptimisticLockException::lockFailed();
                     }
                 }
-
-                if (!$versionedClassFound) {
-                    throw \Doctrine\ORM\OptimisticLockException::lockFailed();
-                }
             }
         }