Merge pull request #3412 from morozov/issues/3410

`CREATE_OPTIONS` is nullable in MySQL
doctrine · Dec 27, 2018 · c23b864 · c23b864
2 parents 51635fe + 28b0190
commit c23b864
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/lib/Doctrine/DBAL/Schema/MySqlSchemaManager.php b/lib/Doctrine/DBAL/Schema/MySqlSchemaManager.php
@@ -312,11 +312,11 @@ public function listTableDetails($tableName)
     /**
      * @return string[]|true[]
      */
-    private function parseCreateOptions(string $string) : array
+    private function parseCreateOptions(?string $string) : array
     {
         $options = [];
 
-        if ($string === '') {
+        if ($string === null || $string === '') {
             return $options;
         }
 

diff --git a/tests/Doctrine/Tests/DBAL/Functional/Schema/MySqlSchemaManagerTest.php b/tests/Doctrine/Tests/DBAL/Functional/Schema/MySqlSchemaManagerTest.php
@@ -531,4 +531,11 @@ public function testEnsureTableWithoutOptionsAreReflectedInMetadata() : void
         self::assertEquals('', $onlineTable->getOption('comment'));
         self::assertEquals([], $onlineTable->getOption('create_options'));
     }
+
+    public function testParseNullCreateOptions() : void
+    {
+        $table = $this->schemaManager->listTableDetails('sys.processlist');
+
+        self::assertEquals([], $table->getOption('create_options'));
+    }
 }