Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CREATE_OPTIONS is nullable in MySQL #3412

Merged
merged 1 commit into from
Dec 27, 2018
Merged

CREATE_OPTIONS is nullable in MySQL #3412

merged 1 commit into from
Dec 27, 2018

Conversation

morozov
Copy link
Member

@morozov morozov commented Dec 17, 2018

I haven't found any documentation on when exactly empty CREATE_OPTIONS is NULL but it looks like it's true for all views and only views.

Fixes #3410.

@morozov morozov added this to the 2.9.2 milestone Dec 17, 2018
Ocramius
Ocramius approved these changes Dec 27, 2018
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@morozov morozov merged commit c23b864 into doctrine:master Dec 27, 2018
@morozov morozov deleted the issues/3410 branch December 27, 2018 20:35
morozov added a commit that referenced this pull request Dec 27, 2018
@morozov
Merge branch 'bpo/2.9/#3412' into 2.9
d16c92b
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@morozov morozov

Labels
Bug MySQL Regression Schema Introspection
Projects
None yet
Milestone
2.9.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@morozov @Ocramius