-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PDOSqlsrv Connection not compatible with PHP 5.3 - 5.4 #2683
Comments
Hi Jack,
Can you simply send a PR against master so we can merge/release a
compatible version?
…On 22 Mar 2017 4:17 a.m., "Jack Polgar" ***@***.***> wrote:
The DBAL versions 2.5.11 and 2.5.12 are can be installed with PHP 5.3 and
5.4, however the PDOSqlsrv Connection
<https://github.com/doctrine/dbal/blob/v2.5.11/lib/Doctrine/DBAL/Driver/PDOSqlsrv/Connection.php#L37>
class uses ::class to resolve a class name
<http://php.net/manual/en/language.oop5.basic.php#language.oop5.basic.class.class>
which is only available to PHP >=5.5
We've had to fix our DBAL package version to 2.5.10
<https://github.com/doctrine/dbal/blob/v2.5.10/lib/Doctrine/DBAL/Driver/PDOSqlsrv/Connection.php>
until we're ready to move off PHP 5.4.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2683>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJakGMqagxnSfhugdg3kkUJo3_ZC5z7ks5roJKsgaJpZM4MkrQ3>
.
|
I believe master is now the 3.x release, so doesn't support old PHPs anyway. I have raised a PR against 2.5 here: #3073 Will it also need applying to 2.6? |
Closing here: we no longer support PHP 5.3 and PHP 5.4. |
@Ocramius Can you clarify regarding support? Reading more carefully, I see that 2.6, not 3.0, is the first release to require PHP 7.1, so this fix is definitely not needed there. However, is the 2.5 branch completely unsupported, or should bugs be raised differently, or do new minimum PHP requirements apply? |
OK, that makes sense. |
Not just yet. Master represents upcoming 2.7 and requires PHP 7.1. |
@Majkl578 Yeah, I misread something when I was flicking through branches. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
The DBAL versions 2.5.11 and 2.5.12 can be installed with PHP 5.3 and 5.4, however the PDOSqlsrv Connection class uses
::class
to resolve a class name which is only available to PHP >=5.5We've had to fix our DBAL package version to 2.5.10 until we're ready to move off PHP 5.4.
The text was updated successfully, but these errors were encountered: