-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Akiban driver #188
Akiban driver #188
Conversation
…all methods are implemented yet.
…nterface. Nearly all methods still need to be implemented.
…o be implemented.
… and schema manager implementations.
…on. This is due to Akiban having a NOW() function that is compatible with MySQL.
…even if it contains tables.
…ception when that function is called.
The official coding standards are mostly the PSR-2 standard. And then on top of that, @guilhermeblanco enforces some rules coming from the Object Calisthenics (but he checks the ORM more than DBAL IIRC) |
… doctrine coding standards.
Ok, this branch is ready for another review. I've updated the code to adhere to the coding standards and applied the suggestions you specified. |
/** | ||
* Akiban Server connection object. | ||
* | ||
* @var resource |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong phpdoc. This is not a resource
Thanks for your review comments. I've applied the majority of them. I'm going to create an implementation that uses PDO and see if I can get that as far. If I can get that functional this weekend, I'll close this pull request and open a new one with that implementation. |
Note that a PDO-based implementation will normally require less code as the statement and connection classes are based on the PDO interfaces :) |
Closing this pull request as it has been superseded by pull request 191. |
An initial implementation of a driver for the Akiban Server. You will notice in the diff there are some features Akiban does not yet support in its latest release but are planned for future releases.
I wasn't sure if pull request was the best way to start a dialog to get this work accepted or whether the mailing list is more appropriate. Please let me know and I will do as suggested.
I am an engineer at Akiban and am very willing to maintain/improve this driver.