Existing columns not found (at least in mysql)

[lucasvanlierop]

Existing columns in the database were not found since dsn was being used instead of just the db name part of the dsn.
Two examples where I ran into this

• Schema tool trying to create existing columns over and over again.
• Migrations not being able to set a primary key for columns created earlier.

Note that this fix is quite basic it might the case the conversion has to happen earlier on in the code for example by adding a 'getDatabaseName()' method to \Doctrine\DBAL\Connection or maybe just apply it in \Doctrine\DBAL\Platforms\MySqlPlatform::getListTableIndexesSQL()?

Please let me know

[doctrinebot]

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DBAL-570

We use Jira to track the state of pull requests and the versions they got
included in.

[deeky666]

Why would you want to pass a DSN to this method when a database name is expected?

[lucasvanlierop]

Well I don't want to (and thus I don't) but that is what the default value becomes when you not pass a database name to this method, see: $this->_conn->getDatabase().

[deeky666]

As far as I can see Connection::getDatabase() calls the driver's getDatabase() method which in turn either returns the dbname connection parameter or performs a SELECT DATABASE() query (MySQL). How can a DSN be returned here by the driver? This seems odd. Is there maybe something wrong with your connection parameters? Looks like the DSN is stored in the dbname connection parameter of Doctrine in your case as I cannot imagine MySQL returns a DSN by querying DATABASE().

[lucasvanlierop]

Good point @deeky666,

Our connection is created in a subsystem of a bigger project which uses PDO. It turned out Doctrine was being fed a PDO dsn string when connection was created like: 'mysql:host=localhost;dbname={dbName}'. The thing is that Doctrine actually works fine with this configuration except for the issue mentioned above. I will split the configuration into separate host and dbname parameters before passing it to doctrine.

Thanks

[deeky666]

@lucasvanlierop I'm sure there will be other issues whenever the dbname parameters is needed by the platform to receive information about the schema. Additionally I wonder how you can successfully establish a connection with PDO if the dbname is a DSN. How can any statement work in this case? However, if you can fix your connection string everything should work as expected. You can close the PR if your problem is solved. :)

[lucasvanlierop]

Well that apparently most stuff still works when a dsn is passed, that's why it took me some time to discover what was wrong, I'll close this PR now

[guilhermeblanco]

As per user request...